Re: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code

[Srinivas Kandagatla]

On 19/08/14 12:55, Ulf Hansson wrote:
> >          writel(host->size, base + MMCIDATALENGTH);
> > >
> > >-       blksz_bits = ffs(data->blksz) - 1;
> > >-       BUG_ON(1 << blksz_bits != data->blksz);
> I don't like this BUG_ON at all, I would prefer if we remove it. The
> original patch "mmc: mmci: Support any block sizes for ux500v2", did
> so as well.
Yes, you are right this is redundant check, mmci_validate_data in 
mmci_request should catch this error anyway. we can remove this check 
totally and use your original patch.


--srini
> Now, if we still think removing it is fragile, let additional tests in
> mmci_validate_data() and return and error code from there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/