Re: [RFC PATCH 8/9] Input: gpio_keys_polled - Make use of device property API

From: Darren Hart
Date: Tue Aug 19 2014 - 11:22:13 EST


On 8/19/14, 4:27, "Mika Westerberg" <mika.westerberg@xxxxxxxxxxxxxxx>
wrote:

>On Mon, Aug 18, 2014 at 10:55:12AM -0700, Jacob Pan wrote:
>> On Sat, 16 Aug 2014 09:53:58 +0300
>> Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>>
>> > From: Aaron Lu <aaron.lu@xxxxxxxxx>
>> >
>> > Make use of device property API in this driver so that both OF based
>> > system and ACPI based system can use this driver.
>> >
>> Do we always assume OF and ACPI _DSD will have the same property name
>> strings? i.e. in this patch "gpios"
>> > + if (device_property_get(dev, "gpios", NULL)) {
>> > - if (!of_find_property(pp, "gpios", NULL)) {
>>
>> Maybe i missed something, but I don't think we can make that assumption
>> in BIOS. If not, what is the point of having unified interface?
>
>We recommend that when it makes sense, the property names in _DSD follow
>the corresponding DT names.
>

This is especially try for platform drivers such as this.

We will be creating subsystem types, "gpios", and defining them in the
_DSD Implementors Guide (per our discussion this morning at Kernel Summit).
--
Darren Hart Open Source Technology Center
darren.hart@xxxxxxxxx Intel Corporation



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/