Re: [PATCH v2 4/6] KVM: VMX: dynamise PLE window

From: Paolo Bonzini
Date: Thu Aug 21 2014 - 09:19:01 EST


Il 21/08/2014 14:42, Radim KrÄmÃÅ ha scritto:
> 2014-08-21 14:29+0200, Paolo Bonzini:
>> Il 21/08/2014 13:54, Radim KrÄmÃÅ ha scritto:
>>> Guity as charged.
>>> Using 0/1 or true/false in this context directly would be pretty bad ...
>>> Is enum fine? (SHIRINK_PLE_WINDOW, GROW_PLE_WINDOW?)
>>
>> I prefer good old Ctrl-C Ctrl-V (adjusted for your favorite editor). :)
>
> I, I should be able to do it, but nightmares are going to last a while.
>
> (And to lower chances of v4: are tracepoint macros, like for kvm_apic,
> frowned upon now?)

Nah, go ahead. But is there any example of #define like what you were
doing? I tried grepping for "#define.*[a-z]\(" and didn't get anything
similar.

Paolo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/