Re: [PATCH] gpio: omap: Fix interrupt names

From: Javier Martinez Canillas
Date: Thu Aug 21 2014 - 09:57:41 EST


Hello,

On Thu, Aug 21, 2014 at 3:37 PM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
> On Thursday 21 August 2014 09:19 AM, Nishanth Menon wrote:
>> When viewing the /proc/interrupts, there is no information about which
>> GPIO bank a specific gpio interrupt is hooked on to. This is more than a
>> bit irritating as such information can esily be provided back to the
>> user and at times, can be crucial for debug.
>>
>> So, instead of displaying something like:
>> 31: 0 0 GPIO 0 palmas
>> 32: 0 0 GPIO 27 mmc0
>>
>> Display the following with appropriate device name:
>> 31: 0 0 4ae10000.gpio 0 palmas
>> 32: 0 0 4805d000.gpio 27 mmc0
>>
>> This requires that we create irq_chip instance specific for each GPIO
>> bank which is trivial to achieve.
>>
>> Signed-off-by: Nishanth Menon <nm@xxxxxx>
>> ---
>> based on v3.17-rc1
> Looks good..
> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>

Looks good to me as well.

Acked-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/