Re: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down

From: Felipe Balbi
Date: Thu Aug 21 2014 - 13:08:30 EST


On Thu, Aug 21, 2014 at 09:48:04AM -0700, Tony Lindgren wrote:
> Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect")
> added twl4030_id_workaround_work() to deal with lost interrupts
> after ID pin goes down. However, this currently only works for the
> insertion. The PHY interrupts are not working after disconnecting
> an USB-A device from the board, and the deeper idle states for
> omap are blocked as the USB controller stays busy.
>
> The issue can be solved by calling delayed work from twl4030_usb_irq()
> when ID pin is down and the PHY is not asleep like we already do
> in twl4030_id_workaround_work().
>
> But as both twl4030_usb_irq() and twl4030_id_workaround_work()
> already do pretty much the same thing, let's call twl4030_usb_irq()
> from twl4030_id_workaround_work() instead of adding some more
> duplicate code.
>
> Fixes: 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect")
> Cc: stable@xxxxxxxxxxxxxxx # v3.12+
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

looks ok to me:

Acked-by: Felipe Balbi <balbi@xxxxxx>

--
balbi

Attachment: signature.asc
Description: Digital signature