Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

From: Tony Lindgren
Date: Thu Aug 21 2014 - 13:21:17 EST


* Felipe Balbi <balbi@xxxxxx> [140821 10:09]:
> On Thu, Aug 21, 2014 at 09:43:46AM -0700, Tony Lindgren wrote:
> > @@ -744,6 +778,9 @@ static int twl4030_usb_probe(struct platform_device *pdev)
> > return status;
> > }
> >
> > + pm_runtime_mark_last_busy(&pdev->dev);
> > + pm_runtime_put(&pdev->dev);
>
> don't you wanna do a put_autosuspend() here instead ?

Sure yeah makes sense as the twl4030_phy_init() usually
runs shortly after.

> Other than that
>
> Acked-by: Felipe Balbi <balbi@xxxxxx>

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/