[PATCH] arm64/crypto: remove redundant update of data

From: Colin King
Date: Sun Aug 24 2014 - 16:38:54 EST

From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Originally found by cppcheck:

[arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of
function parameter has no effect outside the function. Did you
forget dereferencing it?

Updating data by blocks * SHA256_BLOCK_SIZE at the end of
ha2_finup is redundant code and can be removed.

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
arch/arm64/crypto/sha2-ce-glue.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c
index c294e67..ae67e88 100644
--- a/arch/arm64/crypto/sha2-ce-glue.c
+++ b/arch/arm64/crypto/sha2-ce-glue.c
@@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data,
sha2_ce_transform(blocks, data, sctx->state, NULL, len);
- data += blocks * SHA256_BLOCK_SIZE;

static int sha224_finup(struct shash_desc *desc, const u8 *data,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/