Re: [PATCH] staging:iio: moved platform_data into include/linux/iio

[Lars-Peter Clausen]

On 08/25/2014 01:49 PM, Sharma, Sanjeev wrote:
> -----Original Message-----
> From: Lars-Peter Clausen [mailto:lars@xxxxxxxxxx]
> Sent: Monday, August 25, 2014 1:39 PM
> To: Sharma, Sanjeev; sanjeev sharma
> Cc: jic23@xxxxxxxxxx; gregkh; linux-iio@xxxxxxxxxxxxxxx; devel; linux-kernel
> Subject: Re: [PATCH] staging:iio: moved platform_data into include/linux/iio
>
> On 08/25/2014 09:17 AM, Sharma, Sanjeev wrote:
> > Hello Lars,
> >
> > As per your suggestion Can I move complete Driver out of staging specially SPI ADC Driver.
>
> Only if they are cleaned up first. All of the drivers that are still in staging do have issues, otherwise we'd already had moved them. A few of them are OK codestyle wise, but do have ABI issues which need to be resolved before they can be moved.
>
> - Lars
>
> Where I can find ABI issues which need to be resolved so that these can be looked upon.

Compare the sysfs files and their behavior that the driver registers with 
what is documented in the IIO ABI spec[1]. If you can't find it in the 
documentation it either needs to be documented or updated to use the 
existing ABI correctly. Note that this is not necessarily trivial and may 
require in-depth knowledge and understanding of the IIO ABI.

Thanks,
- Lars

[1] 
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/ABI/testing/sysfs-bus-iio

> -Sanjeev
> > Regards
> > Sanjeev Sharma
> >
> > -----Original Message-----
> > From: Lars-Peter Clausen [mailto:lars@xxxxxxxxxx]
> > Sent: Wednesday, August 20, 2014 12:20 PM
> > To: sanjeev sharma
> > Cc: Sharma, Sanjeev; jic23@xxxxxxxxxx; gregkh;
> > linux-iio@xxxxxxxxxxxxxxx; devel; linux-kernel
> > Subject: Re: [PATCH] staging:iio: moved platform_data into
> > include/linux/iio
> >
> > On 08/20/2014 08:44 AM, sanjeev sharma wrote:
> > > Hi,
> > >
> > > This was the action item(TO-DO). IMO, it make sense to move into
> > > include/linux/iio because IIO complete subsystem may take some time.
> >
> > The code that is in staging is not supposed to 'leak' outside of staging. So either you move the driver as a whole out of staging or leave it there, but do not move individual files of the driver out of staging. The action item is for when the driver is moved out of staging.
>
> NïïïïïrïïyïïïbïXïïÇvï^ï)Þ{.nï+ïïïï{ïï*"ïï^nïrïïïzïïïhïïïï&ïïïGïïïhï(ïéïÝj"ïïïmïïïïïzïÞïïïfïïïhïïï~ïmml==

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/