Re: [PATCH] net: bnx2x: fix build error with ptp

From: Randy Dunlap
Date: Mon Aug 25 2014 - 16:14:16 EST


Note: This patch fixes a build error in linux-next (not in mainline).


On 08/25/14 13:11, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> bnx2x uses ptp functions, so it should select the provider of
> those functions (PTP_1588_CLOCK). Fixes these build errors:
>
> drivers/built-in.o: In function `__bnx2x_remove':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
> undefined reference to `ptp_clock_unregister'
> drivers/built-in.o: In function `bnx2x_register_phc':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
> undefined reference to `ptp_clock_register'
> drivers/built-in.o: In function `bnx2x_get_ts_info':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
> undefined reference to `ptp_clock_index'
>
> Reported-by: Jim Davis <jim.epost@xxxxxxxxx>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/broadcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> ===================================================================
> --- linux-next-20140825.orig/drivers/net/ethernet/broadcom/Kconfig
> +++ linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> @@ -122,6 +122,7 @@ config TIGON3
> config BNX2X
> tristate "Broadcom NetXtremeII 10Gb support"
> depends on PCI
> + select PTP_1588_CLOCK
> select FW_LOADER
> select ZLIB_INFLATE
> select LIBCRC32C
> --


--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/