Re: [PATCH v6 2/4] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy()

From: David Miller
Date: Mon Aug 25 2014 - 20:26:12 EST

From: Jonas Jensen <jonas.jensen@xxxxxxxxx>
Date: Mon, 25 Aug 2014 16:22:22 +0200

> build_skb() is used to make skbs out of existing RX ring memory
> which is bad because the RX ring is allocated only once, on probe.
> Memory corruption occur because said memory is reclaimed, i.e.
> __kfree_skb() (and eventually put_page()).
> Replace build_skb() with netdev_alloc_skb_ip_align() and use memcpy().
> Remove SKB_DATA_ALIGN() from RX buffer size while we're at it.
> Addresses
> Signed-off-by: Jonas Jensen <jonas.jensen@xxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at