Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators
From: Mark Brown
Date: Tue Aug 26 2014 - 03:17:48 EST
On Mon, Aug 25, 2014 at 08:40:40AM -0700, Doug Anderson wrote:
> On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas
> > I see, so probably until we have a way to define the operating mode for
> > each regulator using DT we should set the opmode to normal when enabling a
> > regulator independently of the value the hardware register reported on probe.
> > Can you please test the following change  so I can post as a proper
> > patch? Doug, Mark do you think that forcing the regulator to opmode normal
> > when enabling is the right solution here?
> IMHO that makes sense.
No, this doesn't make any obvious sense to me at all. Picking normal as
a default if the hardware reads back off due to overlapping
impelementation or something *might* make sense but not overwriting the
hardware state without explicit permission from the machine integration
is a key goal for the regulator API.
Description: Digital signature