Re: [PATCH v2 2/5] MFD: RK808: Add new mfd driver for RK808

[Chris Zhong]

On 08/26/2014 05:22 PM, Lee Jones wrote:
> On Mon, 25 Aug 2014, Chris Zhong wrote:
> > On 08/20/2014 05:21 PM, Lee Jones wrote:
> > > On Wed, 20 Aug 2014, Chris Zhong wrote:
> > >
> > > > The RK808 chip is a power management IC for multimedia and handheld
> > > > devices. It contains the following components:
> > > >
> > > > - Regulators
> > > > - RTC
> > > >
> > > > The rk808 core driver is registered as a platform driver and provides
> > > > communication through I2C with the host device for the different
> > > > components.
> > > >
> > > > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> > > > ---
> [...]
>
> > > > +	rk808->pdata = pdata;
> > > Remove pdata from 'struct rk808'.  You can obtain it from dev.
> > Can I keep this pdata in rk808, because it is used in the regulator driver.
> > The one obtain from dev maybe empty.
> If the one in dev is empty, you should populate that instead.

So, should I malloc a pada, and assign it to client->dev?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/