Re: [PATCH] sound: pci: ctxfi: prink replacement

From: Takashi Iwai
Date: Tue Aug 26 2014 - 06:33:34 EST

At Tue, 26 Aug 2014 15:43:24 +0530,
Sudip Mukherjee wrote:
> printk replaced with corresponding pr_err and pr_alert
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
> Initially started by copy-paste but as Takashi suggested it was done by a script.
> bash script is as follows :
> OLD="printk(KERN_ERR \?"
> OLD1="printk(KERN_ALERT \?"
> NEW="pr_err("
> NEW1="pr_alert("
> TFILE="/tmp/out.tmp.$$"
> for f in *.c
> do
> sed "s/$OLD/$NEW/g" "$f" > $TFILE && mv $TFILE "$f"
> sed "s/$OLD1/$NEW1/g" "$f" > $TFILE && mv $TFILE "$f"
> done

All these can be a single call of sed :)

> this patch will generate a warning from checkpatch for an unnecessary space before new line and has not been fixed as this patch is only for printk replacement.

Better to put such information into the changelog.

Do you have the patch reformatting the broken lines, too?
If yes, I'll wait for it, as we should apply both such patches at

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at