Re: [PATCH] net: stmmac: add dcrs parameter

[Giuseppe CAVALLARO]

On 8/26/2014 2:35 PM, Vince Bridgers wrote:
> Hi Peppe,
>
> > > In the Synopsys EMAC case, carrier sense is used to stop transmitting
> > > if no carrier is sensed during a transmission. This is only useful if
> > > the media in use is true half duplex media (like obsolete 10Base2 or
> > > 10Base5). If no one in using true half duplex media, then is it
> > > possible to set this disable by default? If we're not sure, then
> > > having an option feels like the right thing to do.
> >
> >
> > Indeed this is what I had done in the patch.
> >
> > http://git.stlinux.com/?p=stm/linux-sh4-2.6.32.y.git;a=commit;h=b0b863bf65c36dc593f6b7b4b418394fd880dae2
> >
> > Also in case of carrier sense the frame will be dropped in any case
> > later.
> >
> > Let me know if you Acked this patch so I will rebase it on
> > net.git and I send it soon
> >
> > peppe
>
> Yes, this looks good to me. I don't expect anyone is using 10Base2 or
> 10Base5 anymore, so it's ok to disable DCRS by default.
>
> ack
>
> All the best,

thx so much, I will send this patch (with your Acked-by) and ported on
net.git soon.

Chen-Yu, Ley Foon, pls let me know if it is ok for you as well

Kind Regards
Peppe

> Vince

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/