Re: [PATCH v5 1/3] pwm: rockchip: Allow polarity invert on rk3288
From: Thierry Reding
Date: Tue Aug 26 2014 - 09:41:51 EST
On Mon, Aug 25, 2014 at 03:59:25PM -0700, Doug Anderson wrote:
> The rk3288 has the ability to invert the polarity of the PWM. Let's
> enable that ability. Note that this increases pwm_cells to 3 for
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Reviewed-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
> Changes in v5: None
> Changes in v4:
> - Updated comment not to add caveats about pwm_cells 3.
> - rockchip_pwm_set_polarity() is now static.
> - Separate pwm_ops for v1 and v2; no set_polarity() in v1.
> - Added a blank line.
> Changes in v3:
> - Don't store a private copy of polarity.
> - Use true instead of 1.
> - Cleanup init order with "has_invert".
> .../devicetree/bindings/pwm/pwm-rockchip.txt | 4 +-
> drivers/pwm/pwm-rockchip.c | 57 ++++++++++++++++++----
> 2 files changed, 50 insertions(+), 11 deletions(-)
Description: PGP signature