[PATCH 0/5 v3] irq / PM: Suspend-to-idle wakeup interrupts

From: Rafael J. Wysocki
Date: Tue Aug 26 2014 - 19:38:13 EST


On Monday, August 11, 2014 03:56:46 PM Rafael J. Wysocki wrote:
> Hi,
> I thought I'd just refresh the previous patchset, but in the meantime I found
> a way to avoid adding overhead to note_interrupt(), so I decided to change the
> approach.
> Patch [2/6] fixes the problem with IRQF_NO_SUSPEND and shared interrupts. The
> idea is to use wrapper handlers for all irqactions of the shared IRQs where at
> least one of them has IRQF_NO_SUSPEND set. Since the wrapper handler is now
> installed for all irqactions in the given irq_desc, it can track the return
> codes from the original handlers and "suspend" the IRQ if the interrupt is going
> to be unhandled eventually. All described in the changelog. This is independent
> of the handling of wakeup interrupts for suspend-to-idle.
> Patch [3/6] makes IRQs configured for system wakeup with enable_irq_wake() work
> for suspend to idle. It does that by using a (different) wrapper handler for
> all irqactions in the wakeup irq_descs and that wrapper handler takes care of
> all the ugly details. Again, all described in the changelog.
> Patches [1/6], [4-5/6] are unmodified and the last one addes documentation.

It has occured to me recently that trying to address two different issues at
once in one patchset may be more confusing than it has to be, so the following
series has one and only one purpose which is to make enable_irq_wake() interrupts
wake up from suspend-to-idle while avoiding the shared interrupts pain.

The way it works is that for each IRQD_WAKEUP_STATE IRQ (a) all of the interrupt
handlers are substituted for by a special "wakeup mode" handler and (b) the
IRQ is re-enabled right before entering the suspend-to-idle loop. After a wakeup
interrupt all is restored to the previous state left by suspend_device_irqs().

The "wakeup mode" handler triggers a system wakeup, disables the IRQ and marks
it as "suspended" and "pending".

To me, all of this is relatively straightforward and the handling of
IRQF_NO_SUSPEND for shared interrupts, which is a separate problem, can be
addressed on top of it later (make no mistake, I still think that it should be

The patches are as follows:

[1/5] Mechanism to wake up the system or abort suspend in progress automatically.
[2/5] Wakeup interrupts support for suspend-to-idle.
[3/5] Set IRQCHIP_SKIP_SET_WAKE for x86 IOAPIC IRQ chips.
[4/5] Make PCIe PME wake up from suspend to idle.
[5/5] Documentation.

Patches [1/5] and [3-4/5] have not been changed since I posted them previously
and patch [5/5] has been updated to reflect the focus on wakeup (I removed the
paragraph on IRQF_NO_SUSPEND vs shared interrupts from it).

All tested on MSI Wind.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/