Re: [PATCH V2 00/18] backlight: fix checkpatch warnings

From: Lee Jones
Date: Wed Aug 27 2014 - 03:14:15 EST


On Wed, 27 Aug 2014, Jingoo Han wrote:
> This patchset fixes checkpatch warnings as follows.
> There is no functional change.
>
> WARNING: Missing a blank line after declarations
> WARNING: else is not generally useful after a break or return
> WARNING: void function return statements are not generally useful
>
> Changes for V2
> - Added Lee Jones's Acked-by for 1~18th patches, except for 17th patch.
> - Fixed 17th patch, per Lee Jones's feedback.
>
> Jingoo Han (18)
> backlight: adp5520: add blank line after declarations
> backlight: adp8860: add blank line after declarations
> backlight: adp8870: add blank line after declarations
> backlight: ams369fg06: remove 'else' after a return
> backlight: corgi_lcd: add blank line after declarations
> backlight: cr_bllcd: add blank line after declarations
> backlight: ili922x: remove 'else' after a return
> backlight: ld9040: remove 'else' after a return
> backlight: lm3639: remove unnecessary return statements
> backlight: lms501kf03: remove 'else' after a return
> backlight: lp855x: add blank line after declarations
> backlight: pcf50633: add blank line after declarations
> backlight: s6e63m0: remove 'else' after a return
> backlight: tdo24m: add blank line after declarations
> backlight: wm831x_bl: add blank line after declarations
> backlight: jornada720: remove 'else' after a return
> backlight: jornada720: remove 'else' after a return
> backlight: omap1: add blank line after declarations

I'll wait to see if Bryan has anything to add. If not, I'll apply
them in a couple of days.

> ---
> drivers/video/backlight/adp5520_bl.c | 1 +
> drivers/video/backlight/adp8860_bl.c | 3 +++
> drivers/video/backlight/adp8870_bl.c | 4 ++++
> drivers/video/backlight/ams369fg06.c | 6 +++---
> drivers/video/backlight/corgi_lcd.c | 1 +
> drivers/video/backlight/cr_bllcd.c | 1 +
> drivers/video/backlight/ili922x.c | 11 ++++++-----
> drivers/video/backlight/jornada720_bl.c | 6 +++---
> drivers/video/backlight/jornada720_lcd.c | 6 +-----
> drivers/video/backlight/ld9040.c | 6 +++---
> drivers/video/backlight/lm3639_bl.c | 2 --
> drivers/video/backlight/lms501kf03.c | 12 ++++++------
> drivers/video/backlight/lp855x_bl.c | 2 ++
> drivers/video/backlight/omap1_bl.c | 1 +
> drivers/video/backlight/pcf50633-backlight.c | 1 +
> drivers/video/backlight/s6e63m0.c | 12 ++++++------
> drivers/video/backlight/tdo24m.c | 2 ++
> drivers/video/backlight/wm831x_bl.c | 1 +
> 18 files changed, 45 insertions(+), 33 deletions(-)
>
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/