Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

From: Herbert Xu
Date: Wed Aug 27 2014 - 09:35:45 EST

On Tue, Aug 26, 2014 at 11:36:54AM +0200, Stephan Mueller wrote:
> The max_addtllen and max_req are defined in drbg_cores[] in crypto/drbg.c for
> each DRBG type. As size_t on a 32 bit system is 32 bit the bit shifts would
> not work either.
> Thus, I am wondering whether the just applied patch would need to go to Linus
> tree too? I would think that the following patch would be in order:

Have you actually tested this on a 32-bit box? If so and it
actually works then I'd be happy to push it.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at