Re: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf
From: Andi Kleen
Date: Wed Aug 27 2014 - 12:37:35 EST
On Wed, Aug 27, 2014 at 11:53:57AM +0200, Thomas Gleixner wrote:
> On Wed, 27 Aug 2014, Thomas Gleixner wrote:
> > On Tue, 26 Aug 2014, Andi Kleen wrote:
> > > > So what's the point of making the obvious onliner patch
> > > >
> > > > - case 71:
> > > >
> > > > into something which reorders the sorted case numbers?
> > >
> > > This was a merging mistake. I'll fix it to be a one liner.
> > >
> > > > And of course, this patch is missing any explanation WHY 71 is
> > > > incorrect and how it got there in the first place.
> > >
> > > 71 is a Broadwell, as you would know if you had read the next patch.
> > And why on earth do I need to read the next patch to figure out what
> > the heck this patch is doing?
> > Just because it's written by someone who gives a shit?
> > Your unwillingness to cooperate and your advisory resistance are
> > slowly approaching the Krause level...
> And after reading the next patch I still can't see that 71 is a
> broadwell, because the next patch merily adds haswell names to the
> numbers. Neither of the following patches has the magic 71
> incorporated. The only model number related to broadwell is 61 in
> patch 3/5.
Ok fair enough.
It was true for v1, but not for v2.
> Try again when you figured yourself out what number means what and why
> 71 is bogus.
71 is definitely not a Haswell, but a Broadwell.
However it was removed from the Broadwell patch based on Peter's
So technically the patch is not needed right now because there
would be no duplicates (unless 71 was readded), so the compiler
would not complain.
However it's still incorrect for Haswell, so I maintain removing
it is the right thing to do.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/