Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw

From: Tomasz Figa
Date: Wed Aug 27 2014 - 14:32:48 EST

On 26.08.2014 13:37, Javier Martinez Canillas wrote:
> + /*
> + * If the regulator is disabled and the system warm rebooted,
> + * the hardware reports OFF as the regulator operating mode.
> + * Default to operating mode NORMAL in that case.
> + */
> + if (val == MAX77802_OPMODE_OFF)
> + max77802->opmode[id] = MAX77802_OPMODE_NORMAL;
> + else
> + max77802->opmode[id] = val;

I might be missing something, but I believe I see a flaw here. If after
a cold boot opmode is something else than OFF or NORMAL, the kernel
starts, turns the regulator off and does warm reboot, the setting is
lost and the regulator is switched to NORMAL mode.

Best regards,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at