Re: [PATCH 1/2] ARM: LPAE: load upper bits of early TTBR0/TTBR1
From: Will Deacon
Date: Thu Aug 28 2014 - 07:03:22 EST
On Wed, Aug 27, 2014 at 04:45:24PM +0100, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 9:01 PM, Konstantin Khlebnikov <koct9i@xxxxxxxxx> wrote:
> > On Wed, Aug 27, 2014 at 7:26 PM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
> >> It seems the patch wasn't tested on any real platform, I did on my
> >> CA15 based platform - it breaks boot. Simply reverting the patch gets
> >> it going again. I am happy to try any fix.
> > Please try to remove adcls line.
> > Seems like this affects only systems where PHYS_OFFSET == PAGE_OFFSET.
> > --- a/arch/arm/mm/proc-v7-3level.S
> > +++ b/arch/arm/mm/proc-v7-3level.S
> > @@ -146,7 +146,6 @@ ENDPROC(cpu_v7_set_pte_ext)
> > mov \tmp, \ttbr1, lsr #(32 - ARCH_PGD_SHIFT) @ upper bits
> > mov \ttbr1, \ttbr1, lsl #ARCH_PGD_SHIFT @ lower bits
> > addls \ttbr1, \ttbr1, #TTBR1_OFFSET
> > - adcls \tmp, \tmp, #0
> > mcrr p15, 1, \ttbr1, \tmp, c2 @ load TTBR1
> > mov \tmp, \ttbr0, lsr #(32 - ARCH_PGD_SHIFT) @ upper bits
> > mov \ttbr0, \ttbr0, lsl #ARCH_PGD_SHIFT @ lower bits
> Yup, restores boot.
Can somebody write this up as a proper patch and put it in the patch system
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/