Re: [PATCH] irqchip: keystone: remove warning unsigned 'kirq->irq' is never less than zero

From: Grygorii Strashko
Date: Thu Aug 28 2014 - 13:27:09 EST

Hi Jason,

On 08/28/2014 08:16 PM, Grygorii Strashko wrote:
Remove static checker warning:

drivers/irqchip/irq-keystone.c:166 keystone_irq_probe()
warn: unsigned 'kirq->irq' is never less than zero.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Sorry, forgot to mention that this is incremental fix for the patch
"[PATCH v2] irqchip: add keystone irq controller ip driver" which is
in linux-next already.

drivers/irqchip/irq-keystone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-keystone.c b/drivers/irqchip/irq-keystone.c
index fea26bc..608abf9 100644
--- a/drivers/irqchip/irq-keystone.c
+++ b/drivers/irqchip/irq-keystone.c
@@ -36,7 +36,7 @@ struct keystone_irq_device {
struct device *dev;
struct irq_chip chip;
u32 mask;
- u32 irq;
+ int irq;
struct irq_domain *irqd;
struct regmap *devctrl_regs;
u32 devctrl_offset;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at