Re: [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

From: Courtney Cavin
Date: Fri Aug 29 2014 - 20:44:55 EST


On Sat, Aug 30, 2014 at 02:14:07AM +0200, Stephen Boyd wrote:
> On 08/29/14 16:41, Courtney Cavin wrote:
> > On Sat, Aug 30, 2014 at 01:14:23AM +0200, Bjorn Andersson wrote:
> >> From: Kumar Gala <galak@xxxxxxxxxxxxxx>
> >>
> >> Add driver for Qualcomm MSM Hardware Mutex block that exists on
> >> newer Qualcomm SoCs.
> >>
> >> Cc: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
> >> Cc: Eric Holmberg <eholmber@xxxxxxxxxxxxxx>
> >> Cc: Courtney Cavin <courtney.cavin@xxxxxxxxxxxxxx>
> >> Signed-off-by: Kumar Gala <galak@xxxxxxxxxxxxxx>
> >> [bjorn: added pm_runtime calls, from Courtney,
> >> added sfpb-mutex compatible,
> >> updated DT binding documentation formatting]
> >> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> >> ---
> > [...]
> >> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> >> index 3612cb5..2cd39e2 100644
> >> --- a/drivers/hwspinlock/Kconfig
> >> +++ b/drivers/hwspinlock/Kconfig
> >> @@ -8,6 +8,17 @@ config HWSPINLOCK
> >>
> >> menu "Hardware Spinlock drivers"
> >>
> >> +config HWSPINLOCK_MSM
> >> + tristate "MSM Hardware Spinlock device"
> >> + depends on ARCH_QCOM
> > This should also depend on OF, as it won't compile or work without it.
>
> Doesn't ARCH_QCOM imply OF? ARCH_MULTIPLATFORM has a select USE_OF.

Hrm. Apparently.

-Courtney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/