Re: [PATCH] Staging: rtl8821ae: hal_bt_coexist: fix coding style issue

From: Greg KH
Date: Sat Aug 30 2014 - 16:59:19 EST

On Sat, Aug 30, 2014 at 02:10:52PM -0400, An Ha wrote:
> Fix coding style issues, these changes include:
> -Add space between "if" and brackets
> -Add space after comma in an argument
> -Add space between equal sign to separate the variable and the assignment
> -Remove unnecessary curly braces around one-line if statements
> -Remove unnecessary whitespace between two brackets
> -Remove unnecessary whitespace before newline
> -Join else-if statement onto same line as end curly brace
> -Join open curly brace onto same line as if statement
> -Use "foo *" instead of "foo*" for the pointer placement
> -Switch commenting style from C99 comments to C89 comments
> Signed-off-by: An Ha <zero579911@xxxxxxxxx>

That's a lot of different things all to be doing in one single patch.
Please break this up into "one thing at a time per patch" so that it is
reviewable and readable.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at