Re: [PATCH] m68k/atari: Remove obsolete keyboard_tasklet scheduling

From: Michael Schmitz
Date: Sun Aug 31 2014 - 05:07:48 EST

Hi Geert

arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt':
atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'

Has keyboard_tasklet gone for good, or just been conditionalized on CONFIG_VT?

I think the keyboard_tasklet scheduling is no longer needed, as I
believe it's handled by drivers/tty/vt/keyboard.c based on events
received from the input subsystem. So just remove it.

I'd like to test this on real hardware (though ARAnyM does emulate the keyboard ACIA IIRC - if you had a working keyboard there I should find no different),



Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Not tested on real hardware. ARAnyM doesn't have keyboard LEDs.

arch/m68k/atari/atakeyb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
index 95022b04b62d..1e2be1d34635 100644
--- a/arch/m68k/atari/atakeyb.c
+++ b/arch/m68k/atari/atakeyb.c
@@ -170,7 +170,6 @@ repeat:
if (acia_stat & ACIA_RDRF) {
/* received a character */
scancode = acia.key_data; /* get it or reset the ACIA, I'll get it! */
- tasklet_schedule(&keyboard_tasklet);
switch (kb_state.state) {

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at