Re: [PATCH v1 2/5] mfd: lpc_sch: better code manageability with chipset info struct

From: Andy Shevchenko
Date: Mon Sep 01 2014 - 06:25:25 EST

On Mon, 2014-09-01 at 10:16 +0100, Lee Jones wrote:
> On Fri, 22 Aug 2014, Andy Shevchenko wrote:
> > Introduce additional struct to hold chipset info. This chipset
> > info will be used to store features that are supported by specific
> > processor or chipset. LPC_SCH supports SMBUS, GPIO and WDT features.
> > As this code base might expand further to support more processors,
> > this implementation will help to keep code base clean and manageable.
> >
> > Signed-off-by: Chang Rebecca Swee Fun <>
> > Tested-by: Chang Rebecca Swee Fun <>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>


> The first patch would look a great deal cleaner if it had these
> changes in too. Unless you have a really good reason not to, please
> consider squashing them.

The only reason behind is that this patch (in other form) was written by
Rebecca in the first place. I recommended to clean up before, and
actually did that clean up and amended Rebecca's patch.

So, if Rebecca has now objections I could squash it.

Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at