Re: [PATCH] fs: replace int param with size_t for seq_open_private()

From: Rob Jones
Date: Mon Sep 01 2014 - 09:54:42 EST


I don't agree. Ultimately this parameter ends up as a parameter to
kmalloc where it is expected to be a size_t.

On 01/09/14 14:43, Alexey Dobriyan wrote:
void *__seq_open_private(struct file *f, const struct seq_operations *ops,
- int psize)
+ size_t psize)

It should be "unsigned int" at most.
As almost all in-kernel lengths.

Alexey



--
Rob Jones
Codethink Ltd
mailto:rob.jones@xxxxxxxxxxxxxxx
tel:+44 161 236 5575
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/