Re: [PATCH v1 1/5] mfd: lpc_sch: reduce duplicate code

From: Andy Shevchenko
Date: Mon Sep 01 2014 - 10:00:21 EST


On Mon, 2014-09-01 at 14:46 +0100, Lee Jones wrote:

[]

> > Okay, what about 1 â IP is present and we have no error, 0 â no ip, no
> > error, -err â error that should be returned, would it work for you?
>
> I would suggest -E<error_message> for messages to be passed back, 0
> for 'everything found and correct' and >0 (#defined of course) for any
> local messages you wish to pass 'IP not found', etc.
>
> > > #define LCP_SKIP_RESOURCE /* Seems resonable? */

Okay, makes sense. Will do this in v2.


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/