Re: [RFC PATCH for Juno 2/2] tty: SBSA compatible UART

From: Mark Brown
Date: Mon Sep 01 2014 - 11:28:11 EST


On Mon, Sep 01, 2014 at 11:06:01PM +0800, Hanjun Guo wrote:
> From: Graeme Gregory <graeme.gregory@xxxxxxxxxx>
>
> This is a subset of pl011 UART which does not supprt DMA or baud rate
> changing.
>
> It is specified in the Server Base System Architecture document from
> ARM.

Is there any reason not to consider submitting this as a TTY driver now
- are there known problems other than the issues with ACPI in general
(I've not reviewed the code at all)? The ACPI binding in this case
seems particularly safe since it's a purposely basic and unconfigurable
IP.

I guess we may want to consider handoff to the full pl011 driver at some
point but there's a bunch of stuff with clocks to worry about before
then.

>
> Signed-off-by: Graeme Gregory <graeme.gregory@xxxxxxxxxx>
> ---

Missing signoff here.

> +config SBSAUART_TTY
> + tristate "SBSA UART TTY Driver"
> + help
> + Console and system TTY driver for the SBSA UART which is defined
> + in the Server Base System Architecure document for ARM64 servers.
> +

depends on ARM || ARM64 || COMPILE_TEST?

Attachment: signature.asc
Description: Digital signature