Re: [PATCH RFC tip/core/rcu] Eliminate deadlock between CPU hotplug and expedited grace periods

From: Peter Zijlstra
Date: Mon Sep 01 2014 - 12:17:46 EST


On Mon, Sep 01, 2014 at 09:05:50AM -0700, Paul E. McKenney wrote:
> > URGH.. I really hate that. The hotplug interface is already too
> > horrible, we should not add such hacks to it.
>
> We do have try_ interfaces to a number of other subsystems, so I don't
> believe that it qualifies as such a hack.

We do indeed, but I'm not sure about adding this to the hotplug stuff.

Also; not really understanding the problem doesn't help.

> > How about ripping that rcu_expedited stuff out instead? That's all
> > conditional anyhow, so might as well not do it.
>
> In what way is the expedited stuff conditional?

synchronize_sched() conditionally calls synchronize_sched_expedited()
and its condition: rcu_expedited, gets set/cleared on pm notifiers and
nr_cpu_ids.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/