Re: [PATCH 1/2] gpu: ipu-v3: Select GENERIC_IRQ_CHIP to fix build error

From: Axel Lin
Date: Mon Sep 01 2014 - 22:26:10 EST


2014-09-02 10:11 GMT+08:00 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
> On Tue, Sep 02, 2014 at 09:47:37AM +0800, Axel Lin wrote:
>> 2014-08-03 10:36 GMT+08:00 Axel Lin <axel.lin@xxxxxxxxxx>:
>> > This driver uses GENERIC_IRQ_CHIP, so it needs to select GENERIC_IRQ_CHIP to
>> > avoid build error.
>> >
>> > Fixes below build errors:
>> > ERROR: "irq_alloc_domain_generic_chips" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_mask_clr_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_mask_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_generic_chip_ops" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_gc_ack_set_bit" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > ERROR: "irq_get_domain_generic_chip" [drivers/gpu/ipu-v3/imx-ipu-v3.ko] undefined!
>> > make[1]: *** [__modpost] Error 1
>> > make: *** [modules] Error 2
>>
>> Hi Greg,
>>
>> I still hit this build error in today's linuex-next tree with below config:
>> ARCH_MULTIPLATFORM && !SOC_IMX5 && !SOC_IMX6Q && !SOC_IMX6SL
>>
>> This driver just moved from staging to gpu.
>> So it's not clear to me who will pick up this patch.
>> Can you pick up this patch?
>
> As the code isn't in the staging tree, why shouldn't it go through the
> drivers/gpu/* maintainer?

scripts/get_maintainer.pl
sent/0001-gpu-ipu-v3-select-GENERIC_IRQ_CHIP-to-fix-build-erro.patch
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (commit_signer:1/1=100%)
Lucas Stach <l.stach@xxxxxxxxxxxxxx> (commit_signer:1/1=100%)
Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:7/7=100%)
linux-kernel@xxxxxxxxxxxxxxx (open list)

I checked the MAINTAINERS file,
I can only find the maintainer for some subfolders of drivers/gpu but no entry
for drivers/gpu/ipu-v3.
So I'm not sure who is the maintainer for drivers/gpu/ipu-v3.

Thanks,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/