Re: [PATCH] irqchip: exynos-combiner: Fix compilation error on ARM64

[Sudeep Holla]

On 02/09/14 16:24, Naveen Krishna Chatradhi wrote:
> The following compilation error occurs on 64-bit Exynos7 SoC:
>
> drivers/irqchip/exynos-combiner.c: In function âcombiner_irq_domain_mapâ:
> drivers/irqchip/exynos-combiner.c:162:2: error: implicit declaration of function âset_irq_flagsâ [-Werror=implicit-function-declaration]
>    set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
>    ^
> drivers/irqchip/exynos-combiner.c:162:21: error: âIRQF_VALIDâ undeclared (first use in this function)
>    set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
>                       ^
> drivers/irqchip/exynos-combiner.c:162:21: note: each undeclared identifier is reported only once for each function it appears in
> drivers/irqchip/exynos-combiner.c:162:34: error: âIRQF_PROBEâ undeclared (first use in this function)
>    set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
>
> Fix the build error by including asm/hardirq.h.

You should avoid using asm headers whenever possible esp. in driver
code. linux/hardirq.h or much better linux/interrupt.h should fix this
error.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/