Re: [PATCH] Revert "leds: convert blink timer to workqueue"

From: Jiri Kosina
Date: Tue Sep 02 2014 - 17:23:03 EST

On Tue, 2 Sep 2014, Bryan Wu wrote:

> On Tue, Sep 2, 2014 at 2:03 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> > This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758.
> >
> > It's broken as it changes led_blink_set() in a way that it can now sleep
> > (while synchronously waiting for workqueue to be cancelled). That's a
> > problem, because it's possible that this function gets called from atomic
> > context (tpt_trig_timer() takes a readlock and thus disables preemption).
> >
> > This has been brought up 3 weeks ago already [1] but no proper fix has
> > materialized, and I keep seeing the problem since 3.18-rc1.
> Is this 3.18-rc1? I think it should be 3.17-rc1, right?

Indeed, brainfart on my side, thanks for noticing.

Jiri Kosina
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at