Re: [PATCH] blk-merge: fix blk_recount_segments
From: Ming Lei
Date: Wed Sep 03 2014 - 00:19:33 EST
On Tue, 02 Sep 2014 10:24:24 -0600
Jens Axboe <axboe@xxxxxxxxx> wrote:
> On 09/02/2014 10:21 AM, Christoph Hellwig wrote:
> > Btw, one thing we should reconsider is where we set
> > QUEUE_FLAG_NO_SG_MERGE. At least for virtio-blk it seems to me that
> > doing the S/G merge should be a lot cheaper than fanning out into the
> > indirect descriptors.
Indirect is always considered first no matter SG merge is off or on,
at least from current virtio-blk implementation.
But it is a good idea to try direct descriptor first, the below simple
change can improve randread(libaio, O_DIRECT, multi-queue) 7% in my test,
and 77% transfer starts to use direct descriptor, and almost all transfer
uses indirect descriptor only in current upstream implementation.