Re: [PATCH v3 0/6] perf: add ability to sample interrupted machine state

[Stephane Eranian]

Hi,

On Mon, Aug 18, 2014 at 1:18 AM, Stephane Eranian <eranian@xxxxxxxxxx> wrote:
> This short patch series add the ability to sample the interrupted
> machine state for each hardware sample. This is useful to analyze
> the state after certain events, for instance for function value
> profiling after a call instruction.
>
> The patch extends the interface with a new PERF_SAMPLE_REGS_INTR
> smaple_type flag. The register to sample can be named in the
> sample_regs_intr bitmask for each event. The name and bit
> position for each register is architecture dependent and
> provided, just like for PERF_SAMPLE_REGS_USER by asm/perf_regs.h.
>
> The support is similar to PERF_SAMPLE_REGS_USER.
>
> On Intel x86, the series includes support for capturing the
> PEBS state as well. When precise sampling is used, the interrupted
> state is collect from the PEBS records, at least partially.
> The PEBS machine state is a subset of the machine state.
>
> The series provides access to this new feature in perf record
> with the -I option. It is possible to display the sampled
> register values using perf report -D.
>
> This patch series is the fundation for a future series adding
> function value profiling.
>
> In V2, we address the issues raised during reviews:
>  - add sample parsing test
>  - shorten perf record option to --intr-regs
>  - added man page for perf record -I/--intr-regs option
>  - refactor register printf code between user and intr regs
>  - rebase to v3.16-rc3
>
> In V3, we rebase to 3.16.0+ and made the modifications suggested
> by PeterZ. We also integrated his patch to improve the layout
> of perf_sample_data.
>
>
> Peter Zijlstra (1):
>   perf: improve perf_sample_data struct layout
>
> Stephane Eranian (5):
>   perf: add ability to sample machine state on interrupt
>   perf/x86: add support for sampling PEBS machine state registers
>   perf tools: add core support for sampling intr machine state regs
>   perf/tests: add interrupted state sample parsing test
>   perf record: add new -I option to sample interrupted machine state
>
any comment on this updated series?

>  arch/x86/kernel/cpu/perf_event_intel_ds.c |   17 +++++++++
>  include/linux/perf_event.h                |   37 ++++++++++---------
>  include/uapi/linux/perf_event.h           |   14 +++++++-
>  kernel/events/core.c                      |   49 +++++++++++++++++++++++--
>  tools/perf/Documentation/perf-record.txt  |    6 ++++
>  tools/perf/builtin-record.c               |    2 ++
>  tools/perf/perf.h                         |    1 +
>  tools/perf/tests/sample-parsing.c         |   55 +++++++++++++++++++++--------
>  tools/perf/util/event.h                   |    1 +
>  tools/perf/util/evsel.c                   |   46 +++++++++++++++++++++++-
>  tools/perf/util/session.c                 |   44 ++++++++++++++++++++---
>  11 files changed, 230 insertions(+), 42 deletions(-)
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/