Re: [PATCH -v3] x86: only load initrd above 4g on second try

[Matt Fleming]

On Tue, 02 Sep, at 03:25:40PM, Yinghai Lu wrote:
> Mantas found that after commit 4bf7111f5016 ("x86/efi: Support initrd
> loaded above 4G"), the kernel freezes at the earliest possible moment
> when trying to boot via UEFI on Asus laptop.
> 
> Revert to old way to load initrd under 4G on first try,
> second try will use above 4G buffer when initrd is too big
> and does not fit under 4G.
> 
> -v2: add print out for second try, and print out files buf address.
> -v3: can not snprintf
> 
> Reported-by: Mantas MikulÄnas <grawity@xxxxxxxxx>
> Tested-by: Anders Darander <anders@xxxxxxxxxxxxxx>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>

I'm still seeing build errors/warnings with this version,

  drivers/firmware/efi/libstub/lib.a(efi-stub-helper.o): In function `handle_cmdline_files':
  efi-stub-helper.c:(.text+0xb7a): undefined reference to `sprintf'

Please drop the second hunk.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/