Re: [PATCH v2] mfd: syscon: Decouple syscon interface from platform devices
From: Boris BREZILLON
Date: Wed Sep 03 2014 - 10:15:35 EST
On Wed, 03 Sep 2014 15:49:04 +0200
Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wednesday 03 September 2014 15:16:11 Boris BREZILLON wrote:
> > I checked that part, and it appears most of the code is already there
> > (see usage of regmap_attach_dev function here ).
> > The only problem I see is that errors are still printed with dev_err,
> > which, AFAIK, will trigger a kernel panic if dev is NULL.
> Actually not:
> static int __dev_printk(const char *level, const struct device *dev,
> struct va_format *vaf)
> if (!dev)
> return printk("%s(NULL device *): %pV", level, vaf);
> return dev_printk_emit(level - '0', dev,
> "%s %s: %pV",
> dev_driver_string(dev), dev_name(dev), vaf);
My bad then (I don't know where I looked at to think NULL dev was not
gracefully handled :-)). Thanks for pointing this out.
Given that, I think it should work fine even with a NULL dev.
I'll give it a try on at91 ;-).
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/