Re: [PATCH 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
From: Sebastian Reichel
Date: Wed Sep 03 2014 - 15:53:28 EST
On Wed, Sep 03, 2014 at 02:06:47PM -0500, Nishanth Menon wrote:
> ti,system-power-controller is more or less the standard way of
> indicating that the PMIC is the system wide power controller and hence
> may be used to switch off the system. Almost ALL TI PMIC drivers and
> many Maxim PMIC drivers follow the same style.
> So support 'ti,system-power-controller' in addition to the usual
> 'ti,use_poweroff' to indicate that the PMIC instance has control for
> switching off the system.
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> .../devicetree/bindings/mfd/twl4030-power.txt | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
> diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> index b9ee7b9..e1dff57 100644
> --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt
> @@ -23,8 +23,11 @@ down during off-idle. Note that this does not work on all boards
> depending on how the external oscillator is wired.
> Optional properties:
> -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or
> - SLEEP-to-OFF transition when the system poweroffs.
> +- ti,system-power-controller OR ti,use_poweroff: This indicates that
> + TWL4030 is the power supply master of the system. With this flag, the
> + chip will initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when
> + the system poweroffs.
I suggest the following wording:
- ti,system-power-controller: This indicates that TWL4030 is the
power supply master of the system. With this flag, the chip will
initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
- ti,use_poweroff: Deprecated name for ti,system-power-controller
Description: Digital signature