Re: [PATCH v2] mfd: syscon: Decouple syscon interface from platform devices

[Alexander Shiyan]

Thu, 04 Sep 2014 10:09:19 +0530 ÐÑ Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>:
> Hi Arnd,
> 
> On Tuesday, September 02, 2014 Arnd Bergmann wrote,
> > To: Pankaj Dubey
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; lee.jones@xxxxxxxxxx; kgene.kim@xxxxxxxxxxx;
> > linux@xxxxxxxxxxxxxxxx; vikas.sajjan@xxxxxxxxxxx; joshi@xxxxxxxxxxx;
> > naushad@xxxxxxxxxxx; thomas.ab@xxxxxxxxxxx; chow.kim@xxxxxxxxxxx;
> > tomasz.figa@xxxxxxxxx; Tomasz Figa; Alexander Shiyan; Michal Simek
> > Subject: Re: [PATCH v2] mfd: syscon: Decouple syscon interface from
> platform
> > devices
...
> > > -struct regmap *syscon_regmap_lookup_by_pdevname(const char *s) -{
> > > -	struct device *dev;
> > > -	struct syscon *syscon;
> > > -
> > > -	dev = driver_find_device(&syscon_driver.driver, NULL, (void *)s,
> > > -				 syscon_match_pdevname);
> > > -	if (!dev)
> > > -		return ERR_PTR(-EPROBE_DEFER);
> > > -
> > > -	syscon = dev_get_drvdata(dev);
> > > -
> > > -	return syscon->regmap;
> > > -}
> > > -EXPORT_SYMBOL_GPL(syscon_regmap_lookup_by_pdevname);
> > 
> > I think this can actually be left intact if that helps with clps71xx.
> > It could be done in a hacky way using bus_find_device_by_name() to keep it
> simple,
> > or in a somewhat nicer way by keeping the syscon platform_driver around
> for the
> > non-DT case.
> > 
> 
> Ok as per our last discussion you mentioned that clps71xx will be soon
> migrating to DT.
> So if that is not going to happen sooner, I would also prefer better keep
> syscon_regmap_lookup_by_pdevname and syscon platform_driver for non-DT case,
> so that this issue should not block this patch.
> 
> So please let's make final call to keep syscon platform_driver for non-DT
> case which eventually
> can be dropped once clps71xx driver migrates to DT based. So that I can
> prepare next patchset
> keeping syscon platform_driver support  and syscon_regmap_lookup_by_pdevname
> API support
> for non-DT case and send across for review. 

Arnd, can you force the applying of the latest clps711x patches to accelerate the process?
I mean latest 3 arm-soc patches from Aug, 19.
After that I will need to make a patch for the SPI and TTY subsystems, then initial DT
support will be introduced.

---