Re: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice

[Joerg Roedel]

On Thu, Sep 04, 2014 at 11:33:42AM +0530, Varun Sethi wrote:
> +	if (!iommu_group_get(dev))
> +		ret = iommu_group_add_device(group, dev);
>  
>  	iommu_group_put(group);
>  	return ret;

Doesn't this additional call to iommu_group_get take a reference to the
iommu_group that needs to be released?


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/