Re: [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation
From: Linus Walleij
Date: Thu Sep 04 2014 - 12:27:20 EST
On Fri, Aug 29, 2014 at 7:58 PM, Soren Brinkmann
> From: Ezra Savard <ezra.savard@xxxxxxxxxx>
> Use of unmask/mask in set_wake was an incorrect implementation. The new
> implementation correctly sets wakeup for the gpio chip's IRQ so the gpio chip
> will not sleep while wakeup-enabled gpio are in use.
> Signed-off-by: Ezra Savard <ezra.savard@xxxxxxxxxx>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
However the problems seems quite generic.
Do you see this kind of error in other GPIO drivers?
IRQchip semantics always make me nervous.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/