Re: [PATCH 2/3] gpio: zynq: Fixed broken wakeup implementation

From: Linus Walleij
Date: Thu Sep 04 2014 - 12:27:20 EST

On Fri, Aug 29, 2014 at 7:58 PM, Soren Brinkmann
<soren.brinkmann@xxxxxxxxxx> wrote:

> From: Ezra Savard <ezra.savard@xxxxxxxxxx>
> Use of unmask/mask in set_wake was an incorrect implementation. The new
> implementation correctly sets wakeup for the gpio chip's IRQ so the gpio chip
> will not sleep while wakeup-enabled gpio are in use.
> Signed-off-by: Ezra Savard <ezra.savard@xxxxxxxxxx>
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>

Patch applied.

However the problems seems quite generic.

Do you see this kind of error in other GPIO drivers?

IRQchip semantics always make me nervous.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at