Re: [PATCH v9 1/3] RTC: RK808: add RTC driver for RK808

[Dmitry Torokhov]

On Wed, Sep 03, 2014 at 09:18:42PM -0700, Doug Anderson wrote:
> Chris,
> 
> On Wed, Sep 3, 2014 at 6:12 PM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> > Adding RTC driver for supporting RTC device present inside RK808 PMIC.
> >
> > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> > Signed-off-by: Zhang Qing <zhangqing@xxxxxxxxxxxxxx>
> >
> > Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
> 
> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> 
> 
> > +       rk808_rtc->irq = platform_get_irq(pdev, 0);
> > +       if (rk808_rtc->irq < 0) {
> > +               dev_err(&pdev->dev, "Wake up is not possible as irq = %d\n",
> > +                       rk808_rtc->irq);
> 
> Technically you shouldn't print the error if it's -EPROBE_DEFER.
> ...but I think that's really unlikely here (I can't imagine any real
> cases where the interrupt parent for RK808 would actually be deferred)
> so I won't push it.

Doug, platform_get_irq() simply iterates through IRQ resources assigned to the
device, which are populated at platform device creation time. The only error it
returns ever is -ENXIO, so we are fine here.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/