Re: [PATCHv10 1/2] edac: altera: Add Altera SDRAM EDAC support.

From: Dinh Nguyen
Date: Thu Sep 04 2014 - 15:14:31 EST

On 08/29/2014 11:02 AM, Borislav Petkov wrote:
> On Mon, Aug 11, 2014 at 10:18:12AM -0500, tthayer@xxxxxxxxxxxxxxxxxxxxx wrote:
>> From: Thor Thayer <tthayer@xxxxxxxxxxxxxxxxxxxxx>
>> This patch adds support for the CycloneV and ArriaV SDRAM controllers.
>> Correction and reporting of SBEs, Panic on DBEs.
>> Signed-off-by: Thor Thayer <tthayer@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>> v2: Use the SDRAM controller registers to calculate memory size
>> instead of the Device Tree. Update To & Cc list. Add maintainer
>> information.
>> v3: EDAC driver cleanup based on comments from Mailing list.
>> v4: Panic on DBE. Add macro around inject-error reads to prevent
>> them from being optimized out. Remove of_match_ptr since this
>> will always use Device Tree.
>> v5: Addition of printk to trigger function to ensure read vars
>> are not optimized out.
>> v6: Changes to split out shared SDRAM controller reg (offset 0x00)
>> as a syscon device and allocate ECC specific SDRAM registers
>> to EDAC.
>> v7: No changes. Bump for consistency.
>> v8: Alphabetize headers.
>> v9: Changes to support a MFD SDRAM controller with nested EDAC.
>> v10: Revert to version 5 (syscon) and fix errors found in v5.
> EDAC bits look ok to me,
> Acked-by: Borislav Petkov <bp@xxxxxxx>
> Dinh, please convert that version information above to a nice commit
> message and add it when applying as it is very useful for future
> reference.

Thank Boris. I had to fix up the patch a bit by making EDAC_ALTERA_MC a
tristate instead of bool to prevent a build error with allmodconfig.

> Thanks.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at