Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

From: Dan Carpenter
Date: Thu Sep 04 2014 - 16:25:59 EST


On Thu, Sep 04, 2014 at 10:11:16PM +0530, Sudip Mukherjee wrote:
> On Wed, Sep 03, 2014 at 12:59:50PM +0300, Dan Carpenter wrote:
> > On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
> > > 1) removed unused variables
> > > 2) fixed sparse warning of context imbalance in 'do_locked_client_insert'
> > > different lock contexts for basic block
> > > 3) removed the call to visor_signalqueue_empty() , this function is
> > > checking whether a signal queue is empty, but the return value
> > > of the function is not beeing used, so it is safe to remove.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> >
> > Looks good. Thanks!
> >
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > regards,
> > dan carpenter
>
> do i need to resend the patch after adding Reviewed-by to it ?
>

No. Greg will reply (perhaps an automated message) when he gets to the
patch. Otherwise your job is done.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/