Re: [PATCH 0/3] Fixing checkpatch errors and warnings for PCI hotplug

[Bjorn Helgaas]

On Mon, Aug 04, 2014 at 08:59:23PM +0200, Quentin Lambert wrote:
> Patch 1 and 2 fix checkpatch coding style warnings.
> 
> Patch 3 fixes chechpatch errors due to assignement
> in if conditions.
> 
> 
> Quentin Lambert (3):
>   PCI hotplug: fix a missing space coding style issue
>   PCI hotplug: fix a simple if coding style issue
>   PCI hotplug: remove assignement from if conditions

I don't mind doing changes like these, but when we do, I want to do the
whole drivers/pci directory at once to minimize the churn.  I don't know
how you did these, but it looks like there are more instances than are
fixed by these patches, e.g.,

    drivers/pci/hotplug/cpcihp_generic.c:	if(!bridge) {
    drivers/pci/pci.c:      if ((i = pci_save_pcie_state(dev)) != 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/