RE: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

From: Chen, Alvin
Date: Fri Sep 05 2014 - 05:36:19 EST


> Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
>
> On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote:
> > This patch enables 'debounce' for the designware GPIO, and it is based
> > on Josef Ahmad's previous work.
>
> Can we split dwapb_read/write introducing and changing from this patch to a
> separate one?
>
Since the 'debounce' feature also needs read/write, if we splite this patch, then for 'debounce',
One patch use readl/writel, and another patch change to dwapb_read/write. It seems duplicate since
the previous patch use readl/writel and the fllowing one change it immediately.
Since this patch is small, could we just make them together? How do you think?