Re: [PATCH] ext4: Fixed styling issues

From: Richard Weinberger
Date: Sun Sep 07 2014 - 09:16:42 EST


On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@xxxxxxxxx> wrote:
> Fixed styling issues as reported by scripts/checkpatch.pl
>
> Signed-off-by: Daniel Bomar <dbdaniel42@xxxxxxxxx>

Please don't run checkpatch.pl on in-kernel files.
The tool is designed to check patches, not files.
Such whitespace cleanups pollute the kernel history, i.e. such that
git blame returns false positives.

The purpose of --file is:
- Checking out-of-tree files (like existing drivers to be imported)
- One notable exception is drivers/staging/, you can run it on these files.

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/