Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

From: Tobias Klauser
Date: Mon Sep 08 2014 - 02:39:00 EST


Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.

On 2014-09-07 at 20:28:25 +0200, anicoara <anicoara@xxxxxxxxxxxx> wrote:

No changelog text? Please add a short notice, describing why this change
is done.

> Signed-off-by: Adrian Nicoara <anicoara@xxxxxxxxxxxx>
> ---
> Patch submitted as part of the Eudyptula challenge.
>
> drivers/staging/ozwpan/ozhcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
> index ba2168f..4cfe56e 100644
> --- a/drivers/staging/ozwpan/ozhcd.c
> +++ b/drivers/staging/ozwpan/ozhcd.c
> @@ -1315,7 +1315,7 @@ static int oz_build_endpoints_for_config(struct usb_hcd *hcd,
> if (num_iface) {
> struct oz_interface *iface;
>
> - iface = kmalloc(num_iface*sizeof(struct oz_interface),
> + iface = kmalloc_array(num_iface, sizeof(struct oz_interface),
> mem_flags | __GFP_ZERO);

The line above should be adjusted to match the opening parenthesis.

> if (!iface)
> return -ENOMEM;
> --
> 2.0.1
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/