Re: [PATCH v4 04/22] perf: Add a capability for AUX_NO_SG pmus to do software double buffering

From: Peter Zijlstra
Date: Mon Sep 08 2014 - 07:31:44 EST


On Mon, Sep 08, 2014 at 02:07:22PM +0300, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:
> > In particular this looks like it will allocate double the total amount
> > of pages and 'loose' half of them. There is no corresponding code in the
> > free path to collect them.
>
> This code makes the biggest high order allocation no bigger than half of
> the total requested size. Then, when I allocate the high-order chunks, I
> do a split_page() on them and everywhere else in the code they are
> treated as individual pages, including the free path. So this patch has
> no implication on freeing. Is this your concern?

Ah right. I completely misread the patch. Sorry for the noise.

Attachment: pgpx3tTyaa_1d.pgp
Description: PGP signature