Re: [PATCH] arm64: LLVMLinux: Provide __aeabi_* symbols which are needed for clang

[Behan Webster]

On 09/08/14 16:01, Mark Charlebois wrote:
> On Sun, Sep 7, 2014 at 12:30 AM, Catalin Marinas
> <catalin.marinas@xxxxxxx> wrote:
> > On 7 Sep 2014, at 03:30, Mark Charlebois <charlebm@xxxxxxxxx> wrote:
> > > On Sat, Sep 6, 2014 at 7:16 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > > > On Friday 05 September 2014 16:23:14 behanw@xxxxxxxxxxxxxxxxxx wrote:
> > > > > + *  Copyright (C) 2012  Mark Charlebois
> > > > > + */
> > > > > +
> > > > > +/*
> > > > > + * EABI routines
> > > > Does EABI specify these function names? I would think that they are
> > > > just random libgcc (whatever that is called in clang) functions.
> > > http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf
> > >
> > > See section 4.3.4 Memory copying, clearing, and setting
> > What does this document have to do with arm64 (AArch64, A64)? We donât
> > need such symbols on arm64. Also, the arm64 kernel links with libgcc (no
> > immediate need AFAICT but the compiler does not guarantee the intrinsics
> > would always be generated inline).
> [reposting in plain text]
>
> This patch was made early in the arm64 kernel support. I just retested
> and you are correct, it is no longer needed.  My apologies to all.

Whoops. I normally check whether a patch is still needed before posting 
them. I seem to have missed that step this time. My apologies as well.

That all being said, I prefer to see patches no longer required, than 
needing them to be upstreamed, so in that this is a win.

Behan

--
Behan Webster
behanw@xxxxxxxxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/